-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New node registration transaction (with proof of possession) #110
Open
tarakby
wants to merge
18
commits into
tarak/update-zxlib
Choose a base branch
from
tarak/develop-pop
base: tarak/update-zxlib
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarakby
changed the title
Tarak/develop pop
New node registration transaction (with proof of possession)
Nov 2, 2024
tarakby
force-pushed
the
tarak/develop-pop
branch
from
January 3, 2025 00:39
20940c8
to
46e9a48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change:
The PR adds a new transaction
SCO.17
to register a node to the network using a new extra parameter: the proof of possession of a staking private key.The PR keeps the old version of the node registration transaction
SCO.03
(without the extra parameter) for backward compatibility of the Hardware wallet. The clients (currently flow-port) would callSCO.17
orSCO.03
depending on the transaction version supported by the chain.Currently, the old the transaction version only is supported. In the near future, only the new transaction version (added by this PR) will be supported though an on-chain contract upgrade. The old version will become obsolete and can be removed from the flow ledger app.
What's the proof of possession of the private key:
Flow protocol uses BLS signature to authenticate participating nodes in the protocol, including the proof of stake consensus algorithm. BLS signature aggregation requires a mechanism to prevent rogue key attacks. The mechanism chosen in the Flow protocol is called the proof of possession (PoP) of the private key. This requires the nodes to present a public proof of knowing the staking private key corresponding to the staking public key they submit to the network. The new registration transaction
SCO.17
is the transaction node operators use to submit their public info to the network, including the PoP of the staking private key.