Do not show starting 04 in pubkey in showpubkey

onflow · Nov 10, 2021 · 8be0a4a · 8be0a4a
1 parent 25d747e
commit 8be0a4a
Show file tree

Hide file tree

Showing 13 changed files with 2 additions and 1 deletion.
diff --git a/app/src/addr.c b/app/src/addr.c
@@ -38,7 +38,8 @@ zxerr_t addr_getItem(int8_t displayIdx,
     switch (displayIdx) {
         case 0:
             snprintf(outKey, outKeyLen, "Pub Key");
-            pageString(outVal, outValLen, (char *) (G_io_apdu_buffer + VIEW_ADDRESS_OFFSET_SECP256K1), pageIdx, pageCount);
+            // +2 is to skip 0x04 prefix that indicates uncompresed key 
+            pageString(outVal, outValLen, (char *) (G_io_apdu_buffer + VIEW_ADDRESS_OFFSET_SECP256K1 + 2), pageIdx, pageCount);
             return zxerr_ok;
         case 1: {
             if (!app_mode_expert()) {

diff --git a/...s/__image_snapshots__/basic-spec-js-basic-checks-show-address-expert-1-snap.png b/...s/__image_snapshots__/basic-spec-js-basic-checks-show-address-expert-1-snap.png
diff --git a/...s/__image_snapshots__/basic-spec-js-basic-checks-show-address-expert-2-snap.png b/...s/__image_snapshots__/basic-spec-js-basic-checks-show-address-expert-2-snap.png
diff --git a/...s/__image_snapshots__/basic-spec-js-basic-checks-show-address-expert-3-snap.png b/...s/__image_snapshots__/basic-spec-js-basic-checks-show-address-expert-3-snap.png
diff --git a/...s/__image_snapshots__/basic-spec-js-basic-checks-show-address-expert-4-snap.png b/...s/__image_snapshots__/basic-spec-js-basic-checks-show-address-expert-4-snap.png
diff --git a/...age_snapshots__/basic-spec-js-basic-checks-show-address-secp-256-k-1-1-snap.png b/...age_snapshots__/basic-spec-js-basic-checks-show-address-secp-256-k-1-1-snap.png
diff --git a/...age_snapshots__/basic-spec-js-basic-checks-show-address-secp-256-k-1-2-snap.png b/...age_snapshots__/basic-spec-js-basic-checks-show-address-secp-256-k-1-2-snap.png
diff --git a/...age_snapshots__/basic-spec-js-basic-checks-show-address-secp-256-k-1-3-snap.png b/...age_snapshots__/basic-spec-js-basic-checks-show-address-secp-256-k-1-3-snap.png
diff --git a/...age_snapshots__/basic-spec-js-basic-checks-show-address-secp-256-k-1-4-snap.png b/...age_snapshots__/basic-spec-js-basic-checks-show-address-secp-256-k-1-4-snap.png
diff --git a/...age_snapshots__/basic-spec-js-basic-checks-show-address-secp-256-r-1-1-snap.png b/...age_snapshots__/basic-spec-js-basic-checks-show-address-secp-256-r-1-1-snap.png
diff --git a/...age_snapshots__/basic-spec-js-basic-checks-show-address-secp-256-r-1-2-snap.png b/...age_snapshots__/basic-spec-js-basic-checks-show-address-secp-256-r-1-2-snap.png
diff --git a/...age_snapshots__/basic-spec-js-basic-checks-show-address-secp-256-r-1-3-snap.png b/...age_snapshots__/basic-spec-js-basic-checks-show-address-secp-256-r-1-3-snap.png
diff --git a/...age_snapshots__/basic-spec-js-basic-checks-show-address-secp-256-r-1-4-snap.png b/...age_snapshots__/basic-spec-js-basic-checks-show-address-secp-256-r-1-4-snap.png