Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Feature EFM Recovery #6885

Draft
wants to merge 489 commits into
base: master
Choose a base branch
from
Draft

WIP: Feature EFM Recovery #6885

wants to merge 489 commits into from

Conversation

jordanschalm
Copy link
Member

No description provided.

durkmurder and others added 30 commits November 13, 2024 16:20
@durkmurder
Added assertions to ensure transaction from recovery epoch to epoch a…
81788e9 
…fter
@durkmurder
Merge branch 'yurii/6331-eject-before-recovery-test' of https://githu…
14e37fa 
…b.com/onflow/flow-go into yurii/6331-eject-before-recovery-test
@durkmurder
Work in progress on adding integration test
97c4177
@durkmurder @AlexHentschel
Update cmd/bootstrap/run/epochs.go
9297c15 
Co-authored-by: Alexander Hentschel <[email protected]>
@durkmurder @AlexHentschel
Apply suggestions from code review
39ae7be 
Co-authored-by: Alexander Hentschel <[email protected]>
@durkmurder
Fixed compilation issues
5207fdb
@durkmurder
Added a separate label for configuration problems. Updated godoc
b334c81
@durkmurder
Apply suggestions from PR review
2168811
@durkmurder
Apply suggestions from PR review
36a3958
@durkmurder @AlexHentschel
Update storage/badger/dkg_state.go
eb968f8 
Co-authored-by: Alexander Hentschel <[email protected]>
@durkmurder
Apply suggestions from PR review
4b2af92
@durkmurder
Apply suggestions from PR review
f577657
@durkmurder
Apply suggestions from PR review
171467c
@durkmurder @AlexHentschel
Update cmd/bootstrap/run/epochs.go
433921c 
Co-authored-by: Alexander Hentschel <[email protected]>
@durkmurder @AlexHentschel
Apply suggestions from code review
7ce3c0c 
Co-authored-by: Alexander Hentschel <[email protected]>
@durkmurder
Apply suggestions from PR review
b2d26a7
@durkmurder
Apply suggestions from PR review
27150c1
@durkmurder
Linted
71aa1be
@durkmurder
Apply suggestions from PR review
1463693
@durkmurder @AlexHentschel
Apply suggestions from code review
d32782c 
Co-authored-by: Alexander Hentschel <[email protected]>
@durkmurder
Linted
bd711e3
changed
b4eb301 
• DKG key -> Random Beacon key
• DKG private key -> Random Beacon private key
@durkmurder @jordanschalm
Apply suggestions from code review
b9e9130 
Co-authored-by: Jordan Schalm <[email protected]>
@durkmurder
Fixed compilation issue
a5ac02c
@durkmurder
Merge pull request #6424 from onflow/khalil/6164-efm-integration-test…
d0c9695 
…-part2
@durkmurder
Refactored encoding and decoding of DKG data during bootstrapping
6b6a240
@durkmurder
Updated godoc
8600101
@jordanschalm
add chunk model changes and encoding tests
e59dc76
@jordanschalm
add servcie event indices to chunk
869feff
@jordanschalm
revert test package change
6e4c8de
jordanschalm and others added 26 commits January 6, 2025 14:54
@jordanschalm
Merge branch 'feature/efm-recovery' into jord/6816-dkg-submission-compat
a1bedc9
@durkmurder
Apply suggestions from PR review
d2c190b
@durkmurder
Apply suggestions from PR review
338756c
@durkmurder
Apply suggestions from PR review
37a7405
@durkmurder
Split test in two
9b368f3
@durkmurder
Added test case for verifiying that key which is not part of RB commi…
4ac3942 
…tee cannot be committed in the Recoverable Random Beacon State Machine
@durkmurder
Added similar test case but for upserting the private key
c975795
@durkmurder
Merge pull request #6815 from onflow/yurii/6725-follow-up-changes
7e6e79d
@jordanschalm
Merge branch 'feature/efm-recovery' into jord/6816-dkg-submission-compat
8fee2f4
@jordanschalm
Merge pull request #6827 from onflow/jord/6816-dkg-submission-compat
3cfafb6 
DKG Result Submission Backward Compatibility
@durkmurder
Added database migration as part of model upgrade for dynamic protoco…
4f59be0 
…l state. Added implementation for DKG end state migration between v1 and v2
@durkmurder
Revert "Added database migration as part of model upgrade for dynamic…
2ad8aaf 
… protocol state. Added implementation for DKG end state migration between v1 and v2"

This reverts commit 4f59be0.
@durkmurder
Added new code for DKGState, deprecated the old one
eb560a1
@durkmurder
Added DB migration for dkg end state
79c8992
@durkmurder
Added post init handler for consensus nodes to migrate the DKG end st…
049b987 
…ate on startup
@durkmurder
Linted
ce4d9c5
@durkmurder
Added a test case to verify that migration is correct
e653253
@durkmurder
Fixed typo
bb19acd
@jordanschalm
Merge branch 'feature/efm-recovery' into yurii/6786-dkg-end-state-bac…
2ab0853 
…kward-compatibility
@durkmurder @jordanschalm
Update dkg.go
0f7adab 
Co-authored-by: Jordan Schalm <[email protected]>
@durkmurder @AlexHentschel
Update storage/badger/operation/dkg.go
497376a 
Co-authored-by: Alexander Hentschel <[email protected]>
@durkmurder
Merge pull request #6861 from onflow/yurii/6786-dkg-end-state-backwar…
75110b3 
…d-compatibility
@jordanschalm
Merge branch 'master' into jord/sync-master-efm-jan14
0ba9fce 
Outstanding conflicts:
- consensus/hotstuff/votecollector/combined_vote_processor_v2_test.go
@jordanschalm
make tidy
6813b22
@jordanschalm
fix vote collector v2 test
af61312 
incorporate changes from #6526
@jordanschalm
update state commitment fixtures
2e7fb47
@jordanschalm jordanschalm changed the title Feature/efm recovery WIP: Feature EFM Recovery Jan 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 45.96739% with 1226 lines in your changes missing coverage. Please review.

Project coverage is 41.12%. Comparing base (0d2b34f) to head (db5a8d7).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
module/dkg/client.go 0.00% 130 Missing ⚠️
storage/mock/epoch_recovery_my_beacon_key.go 0.00% 110 Missing ⚠️
storage/mock/dkg_state_reader.go 0.00% 98 Missing ⚠️
cmd/bootstrap/run/epochs.go 0.00% 95 Missing ⚠️
model/convert/service_event.go 43.42% 63 Missing and 23 partials ⚠️
storage/mock/dkg_state.go 0.00% 69 Missing ⚠️
cmd/consensus/main.go 0.00% 61 Missing ⚠️
utils/unittest/service_events_fixtures.go 64.49% 58 Missing and 2 partials ⚠️
model/flow/service_event.go 9.52% 38 Missing ⚠️
storage/badger/dkg_state.go 74.30% 26 Missing and 11 partials ⚠️
... and 54 more
Additional details and impacted files 
@@            Coverage Diff            @@
##           master    #6885     +/-   ##
=========================================
  Coverage   41.11%   41.12%             
=========================================
  Files        2116     2123      +7     
  Lines      185737   187163   +1426     
=========================================
+ Hits        76368    76971    +603     
- Misses     102952   103739    +787     
- Partials     6417     6453     +36
Flag Coverage Δ
unittests 41.12% <45.96%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik will be requested when the pull request is marked ready for review janezpodhostnik is a code owner

@zhangchiqing zhangchiqing Awaiting requested review from zhangchiqing zhangchiqing will be requested when the pull request is marked ready for review zhangchiqing is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jordanschalm @codecov-commenter @durkmurder @tarakby