[Storage Refactor] Refactor ConsumerProgress

[zhangchiqing]

This PR refactors consumer progress to use badger batch updates instead of transactions.

Also created a ConsumerProgressInitializer to separate the initialization process.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 17.97235% with 178 lines in your changes missing coverage. Please review.

Project coverage is 41.15%. Comparing base (b740fc0) to head (5deb562).
Report is 3 commits behind head on master.

Files with missing lines	Patch %	Lines
storage/mock/batch.go	0.00%	46 Missing ⚠️
storage/mock/db.go	0.00%	44 Missing ⚠️
storage/mock/consumer_progress_initializer.go	0.00%	28 Missing ⚠️
cmd/access/node_builder/access_node_builder.go	0.00%	22 Missing ⚠️
cmd/observer/node_builder/observer_builder.go	0.00%	12 Missing ⚠️
storage/store/consumer_progress.go	78.57%	6 Missing and 3 partials ⚠️
cmd/verification_builder.go	0.00%	7 Missing ⚠️
storage/operation/consume_progress.go	0.00%	4 Missing ⚠️
module/jobqueue/consumer.go	40.00%	2 Missing and 1 partial ⚠️
engine/testutil/nodes.go	0.00%	2 Missing ⚠️
... and 1 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6872      +/-   ##
==========================================
+ Coverage   41.11%   41.15%   +0.03%     
==========================================
  Files        2116     2118       +2     
  Lines      185749   185815      +66     
==========================================
+ Hits        76378    76474      +96     
+ Misses     102954   102920      -34     
- Partials     6417     6421       +4     

Flag	Coverage Δ
unittests	41.15% <17.97%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AlexHentschel]

May I suggest a minor documentation upgrade of line 47 to further improve accuracy of documentation:

flow-go/module/counters/persistent_strict_monotonic_counter.go

Line 47 in fa24125

// - codes.ErrIncorrectValue - if stored value is larger than processed.

Let current denote the counter's current value and processed is the new value.

• According to the documentation, we error codes.ErrIncorrectValue if current > processed. This implies that a Set(processed) operation where processed = current should succeed.
• The error describes, in which cases we reject a new element. Of course, we reject the new element (processed), when it is smaller - this is correctly reflected in the documentation. But we also reject elements that have the same value, which is missing from the documentation.
• Note that this is the difference between monotonous increasing and strict monotonous increasing. Monotonous allows values to repeat (they just can't get smaller). E.g. 8, 12, 13, 13, 13, 100 is a monotonously increasing sequence. But it is not strictly monotonous increasing, because some elements have the same value (13) as the prior element, which is not allowed for strict monotonous increasing.

I would suggest to replace line 47 by

//   - codes.ErrIncorrectValue - if stored value is ≥ processed (requirement of strict monotonous increase is violated).

[zhangchiqing]

NewPersistentStrictMonotonicCounter now only takes a consumer progress that has been initialized. The initialization steps is moved out of the PersistentStrictMonotonicCounter, so that the initialization logic can be reused by other modules, and forces the caller to initialize the progress before being used by the counter.

It also simplifies the counter, as it doesn't need to worry about whether the progress has been initialized or not, since it must have been initialized.

[zhangchiqing]

This is actually renamed from storage/badger/consumer_progress.go, github wasn't able to recognize this move, but think it's a new file.

[zhangchiqing]

This is actually renamed from storage/badger/consumer_progress_test.go, github wasn't able to recognize this move, but think it's a new file.