Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] Trigger OnLog tracer hooks upon successful call & tx results #6860

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m-Peter
Copy link
Collaborator

@m-Peter m-Peter commented Jan 9, 2025

Closes: #6842

This will remove the need for having to trigger this tracer hook on EVM Gateway:

And we will have all the necessary hooks in a single place, instead of being in separate repositories.

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.

Project coverage is 41.18%. Comparing base (47f24e9) to head (ae7f1c7).

Files with missing lines Patch % Lines
fvm/evm/emulator/emulator.go 29.41% 9 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6860   +/-   ##
=======================================
  Coverage   41.18%   41.18%           
=======================================
  Files        2109     2109           
  Lines      185660   185677   +17     
=======================================
+ Hits        76467    76477   +10     
  Misses     102782   102782           
- Partials     6411     6418    +7     
Flag Coverage Δ
unittests 41.18% <29.41%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flow EVM] Trigger OnLog tracing hook for transactions with logs
3 participants