[Access] Unify subscription id with client message id #6847
+122
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From now on, we use only 1 id in request/response messages. This id is called `subscription_id`. A client may provide `subscription_id` in `subscribe` request. If client does not provide it, we generate it ourselves. Clients that use browsers or other async environemnts may use `subscription_id` to correlate response messages with the request ones. `subscription_id` is used in all messages related to subscription. I also remove `success` field from response. We include `subscription_id` field in a resposne in case of OK response. In case of error response, we include `error` field.
illia-malachyn
force-pushed
the
illia-malachyn/6845-unify-subscription-and-message-id
branch
from
8d1e427 to
e5a91d7
Compare
illia-malachyn
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6847 +/- ##
==========================================
- Coverage 41.18% 41.18% -0.01%
==========================================
Files 2109 2109
Lines 185660 185661 +1
==========================================
- Hits 76460 76457 -3
- Misses 102788 102789 +1
- Partials 6412 6415 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Guitarheroua
reviewed
Jan 6, 2025
| ) | ||
| return | ||
| } | ||
|
|
||
| // register new provider | ||
| provider, err := c.dataProviderFactory.NewDataProvider(ctx, msg.Topic, msg.Arguments, c.multiplexedStream) |
There was a problem hiding this comment.
I think we need to provide the subscriptionID for DataProvider as they will also return formatted response, containing topic and subscription ID fields according to this PR #6846
Guitarheroua
reviewed
Jan 6, 2025
| @@ -25,19 +22,13 @@ func newBaseDataProvider( | |||
| subscription subscription.Subscription, | |||
| ) *baseDataProvider { | |||
| return &baseDataProvider{ | |||
| id: uuid.New(), | |||
There was a problem hiding this comment.
So this will be not generated, but set outside.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From commit message:
From now on, we use only 1 id in request/response messages. This id is called
subscription_id.A client may provide
subscription_idinsubscriberequest. If client does not provide it, we generate it ourselves.Clients that use browsers or other async environments may use
subscription_idto correlate response messages with the request ones.subscription_idis used in all messages related to subscription.I also removed
successfield from a response. We includesubscription_idfield in a resposne in case of OK response.In case of error response, we include
errorfield.Closes #6845