Remove buffer gas added in the gas consumption of EVM.dryRun
#6844
+12
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6844 +/- ##
=======================================
Coverage 41.18% 41.18%
=======================================
Files 2109 2109
Lines 185660 185626 -34
=======================================
- Hits 76460 76457 -3
+ Misses 102788 102756 -32
- Partials 6412 6413 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
m-Peter
force-pushed
the
mpeter/dry-run-remove-buffer-gas
branch
from
99d8c10 to
0b7c592
Compare
|
The code looks good, but I'm not too familiar with why we have this and why we can now remove it. Could you please add some text describing this in the PR description? |
Good point 👌 Updated the description #6844 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6843
Relevant issue: #6301
The buffer gas added in
EVM.dryRun, was a best-effort solution, to find the minimum required gas, that would make a transaction succeed. The calculation was based on top of the actual gas used for a given transaction. However, this did have some issues, and it would fail for certain cases.With the implementation of the local state index on EVM Gateway, we have completely reworked the
eth_estimateGasendpoint, and it uses the same logic asGeth, to calculate the minimum required gas needed for a transaction to succeed.With that change deployed, we no longer need to add any buffer gas to the result of
EVM.dryRun. And this can in fact cause confusion to developers, as it is always a bit higher that the gas usage they would get from tracing the same transaction / contract call.