[BFT] Epoch Recovery integration test #6823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/efm-recovery #6823 +/- ##
========================================================
- Coverage 41.81% 41.72% -0.09%
========================================================
Files 1588 2033 +445
Lines 144098 181223 +37125
========================================================
+ Hits 60251 75613 +15362
- Misses 78887 99381 +20494
- Partials 4960 6229 +1269
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jordanschalm
approved these changes
Dec 20, 2024
integration/tests/epochs/cohort2/epoch_recover_from_efm_test.go
Outdated
Show resolved
Hide resolved
integration/tests/epochs/cohort2/epoch_recover_from_efm_test.go
Outdated
Show resolved
Hide resolved
| 3000, | ||
| false, | ||
| dkgIndexMap, | ||
| dkg.KeyShares()[:nConsensusNodes], |
There was a problem hiding this comment.
Suggested change
| dkg.KeyShares()[:nConsensusNodes], | |
| dkgKeyShares, |
AlexHentschel
approved these changes
Jan 3, 2025
integration/tests/epochs/cohort2/epoch_recover_from_efm_test.go
Outdated
Show resolved
Hide resolved
integration/tests/epochs/cohort2/epoch_recover_from_efm_test.go
Outdated
Show resolved
Hide resolved
integration/tests/epochs/cohort2/epoch_recover_from_efm_test.go
Outdated
Show resolved
Hide resolved
integration/tests/epochs/cohort2/epoch_recover_from_efm_test.go
Outdated
Show resolved
Hide resolved
integration/tests/epochs/cohort2/epoch_recover_from_efm_test.go
Outdated
Show resolved
Hide resolved
integration/tests/epochs/cohort2/epoch_recover_from_efm_test.go
Outdated
Show resolved
Hide resolved
Comment on lines
365
to
367
| // At this point we have a node which is part of the consensus committee but not part of the Random Beacon committee and | ||
| // another node which is part of the Random Beacon committee but not part of the consensus committee. | ||
| txArgs, err := run.GenerateRecoverTxArgsWithDKG( |
There was a problem hiding this comment.
If we move step 2 to here, the test would be easier for me to understand as it would more closely emulate a real-world scenario.
If that is possible, we could summarize the test as follows in the documentation (changes highlighted in bold font)
This test will do the following:
- Triggers EFM by turning off the sole collection node before the end of the DKG forcing the DKG to fail.
- Eject the first consensus node by modifying the epoch snapshot.
- Drop the last consensus node from the Random Beacon committee. This hack works only for threshold systems with an even number of participants,
without changing the threshold - hence we need to start this test with 4 consensus nodes.- Generates epoch recover transaction args using the tooling [run.GenerateRecoverTxArgsWithDKG] provided for the governance committee.
- Submit recover epoch transaction.
- Ensure expected EpochRecover event is emitted.
- Ensure the network transitions into the recovery epoch and finalizes the first view of the recovery epoch.
Co-authored-by: Alexander Hentschel <[email protected]> Co-authored-by: Jordan Schalm <[email protected]>
durkmurder
deleted the
yurii/6645-consensus-dkg-symmetric-difference-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6645
Context
This PR implements the most general case where Random beacon committee and consensus committee form a symmetric difference with cardinality 1. More details in the attached issue.