Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Channel size of 20000 and worker count of 100 suggested by Leo. 20000 is approximately equal to 4 hours of execution results.

Co-authored-by: Leo Zhang <[email protected]>
  • Loading branch information
tim-barry and zhangchiqing authored Dec 20, 2024
1 parent d3a1438 commit 602a4cc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions engine/execution/ingestion/uploader/uploader.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ func NewAsyncUploader(uploader Uploader,
maxRetryNumber: maxRetryNumber,
// we use a channel rather than a Fifoqueue here because a Fifoqueue might drop items when full,
// but it is not acceptable to skip uploading an execution result
queue: make(chan *execution.ComputationResult, 100),
queue: make(chan *execution.ComputationResult, 20000),

Check failure on line 38 in engine/execution/ingestion/uploader/uploader.go

View workflow job for this annotation

GitHub Actions / Lint (./)

File is not `goimports`-ed with -local github.com/onflow/flow-go/ (goimports)
}
builder := component.NewComponentManagerBuilder()
for i := 0; i < 3; i++ {
for i := 0; i < 10; i++ {
builder.AddWorker(a.UploadWorker)
}
a.cm = builder.Build()
Expand Down

0 comments on commit 602a4cc

Please sign in to comment.