Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper method interfaces for unsupported API methods #22

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Add proper method interfaces for unsupported API methods #22

merged 3 commits into from
Jan 22, 2024

Conversation

m-Peter
Copy link
Collaborator

@m-Peter m-Peter commented Jan 19, 2024

Closes: #8

Description

Updates the method interfaces to match the ones expected from JSON-RPC specification, and adds tests to cover the expected behavior.

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@m-Peter m-Peter added this to the Flex Testnet Release milestone Jan 19, 2024
@m-Peter m-Peter self-assigned this Jan 19, 2024
@m-Peter m-Peter requested a review from sideninja January 22, 2024 10:18
@m-Peter m-Peter merged commit 1b1548a into onflow:main Jan 22, 2024
1 check passed
@m-Peter m-Peter deleted the unsupported-api-methods branch January 22, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideninja sideninja sideninja approved these changes

Assignees

@m-Peter m-Peter

Labels
None yet
Projects
🌊 Flow 4D
Status: ✅ Done
Milestone
Flex Testnet Release
Development

Successfully merging this pull request may close these issues.

Implement unsupported API methods
2 participants
@m-Peter @sideninja