Use Emulator gRPC host for default access URL and update event types to EVM #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sideninja
reviewed
Jan 22, 2024
| // TODO(m-Peter): These should be updates to the EVM location, | ||
| // as soon as it gets merged. | ||
| var evmEventTypes = []string{ | ||
| "flow.evm.BlockExecuted", |
There was a problem hiding this comment.
how about using:
evm := types.EVMLocation{}
evm.TypeID(nil, string(types.EventTypeTransactionExecuted))
evm.TypeID(nil, string(types.EventTypeBlockExecuted))There was a problem hiding this comment.
Good point 👍 , I will update them as soon as we add flow-go as a dependency. Right now it's not there yet, due to some dependency conflicts with flow-go-sdk I think. I have added a TODO and will update it though.
sideninja
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards: #20
Description
127.0.0.1:3569(emulator Access API)flow.evm.BlockExecuted&flow.evm.TransactionExecuted)For contributor use:
masterbranchFiles changedin the Github PR explorer