Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary method needed for WFLOW handler configuration #141

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Dec 21, 2024

Related: #134

Description

Follow up to #137 removing temporary methods relating to removing type associations which was necessary to reconfigure FlowEVMBridgeConfig for FlowToken <-> WFLOW bridging


For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling self-assigned this Dec 21, 2024
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review December 21, 2024 02:24
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner December 21, 2024 02:24
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.35%. Comparing base (02aab3f) to head (ed8b258).
Report is 215 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   86.19%   87.35%   +1.15%     
==========================================
  Files          18       18              
  Lines         884     1020     +136     
==========================================
+ Hits          762      891     +129     
- Misses        122      129       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling requested review from nvdtf and a team December 21, 2024 02:24
@sisyphusSmiling sisyphusSmiling changed the title Remove temporary method needed for WFLOW handler from FlowEVMBridgeCo… Remove temporary method needed for WFLOW handler configuration Dec 21, 2024
@sisyphusSmiling sisyphusSmiling merged commit 77091f6 into main Jan 6, 2025
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the gio/add-wflow-handler-followup branch January 6, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants