Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Manager: Install all contracts from an address #1867

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

chasefleming
Copy link
Member

@chasefleming chasefleming commented Dec 23, 2024

Closes #1618

Description

Allows a dev to install all contracts at an address instead of requiring a contract name: flow dependencies add testnet://7e60df042a9c0868


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 18.68132% with 74 lines in your changes missing coverage. Please review.

Project coverage is 28.38%. Comparing base (c9c4aba) to head (645a67d).

Files with missing lines Patch % Lines
internal/dependencymanager/dependencyinstaller.go 26.15% 43 Missing and 5 partials ⚠️
internal/dependencymanager/install.go 0.00% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1867      +/-   ##
==========================================
- Coverage   28.55%   28.38%   -0.17%     
==========================================
  Files          95       95              
  Lines        6525     6581      +56     
==========================================
+ Hits         1863     1868       +5     
- Misses       4480     4531      +51     
  Partials      182      182              
Flag Coverage Δ
unittests 28.38% <18.68%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chasefleming chasefleming added the Feature A new user feature or a new package API label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new user feature or a new package API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import address feature for dependency manager
2 participants