Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cadence transaction batching EVM calls #12

Merged
merged 24 commits into from
Nov 7, 2024

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Nov 4, 2024

Closes: #5 #6

Description

ℹ️ Does not include Cadence tests as errored behavior was encountered when interacting with revertible randomness from EVM - CadenceArch revertibleRandom() calls appear to only return 0 and will require further investigation before adding a complete test case for the bundled transaction

  • Adds the primary Cadence transaction which wraps FLOW, approves the ERC721 contract to transfer the flow as payment for minting, and attempts to mint the ERC721
  • Adds stepwise transactions for each of the actions executed in the bundled transaction individually
  • Parses out potential errors in the ERC721 contract using custom errors

For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review November 5, 2024 01:13
@sisyphusSmiling sisyphusSmiling requested a review from a team November 7, 2024 17:17
Base automatically changed from gio/add-random-mint to main November 7, 2024 22:00
@sisyphusSmiling sisyphusSmiling merged commit 5aa3bb2 into main Nov 7, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the gio/add-batched-calls branch November 7, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Compose the example transaction
2 participants