Fix hostname randomisation bug

onebeyond · Feb 11, 2024 · aa61cbf · aa61cbf
1 parent ecbd658
commit aa61cbf
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 - Update guidesmiths references to onebeyond.
 - Dedupe channel poole ready check
 - Remove unnecessary subscription config from busy publisher example
+- Fixed bug where hostname connection order was not properly randomised
 
 ## 17.0.1
 

diff --git a/lib/config/configure.js b/lib/config/configure.js
@@ -132,7 +132,7 @@ module.exports = _.curry((rascalConfig, next) => {
   }
 
   function setConnectionIndex(connection, strategy, index) {
-    connection.index = strategy === 'fixed' ? index : getConnectionIndex(strategy, `${connection.host}:${connection.port}`);
+    connection.index = strategy === 'fixed' ? index : getConnectionIndex(strategy, `${connection.hostname}:${connection.port}`);
   }
 
   function getConnectionIndex(strategy, hostname) {

diff --git a/test/config.tests.js b/test/config.tests.js
@@ -233,7 +233,7 @@ describe('Configuration', () => {
 
       it('should randomise the order of connections, but maintain order across vhosts by host', () => {
         const results = [];
-        for (let i = 0; i < 10; i++) {
+        for (let i = 0; i < 100; i++) {
           configure(
             {
               vhosts: {
@@ -336,7 +336,7 @@ describe('Configuration', () => {
             },
           );
         }
-        assert.ok(_.uniq(results).length > 1);
+        assert.ok(_.uniq(results).length > 10);
       });
 
       it('should honour the order of connections with fixed connection strategy', () => {