Added ability to add parentId into api calls #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiomaistro
requested changes
Sep 11, 2023
| @@ -21,6 +23,10 @@ export class DataAdaptor extends ObApiClient { | |||
| filters.push(`limit=${query.limit}`); | |||
| filters.push(this.constructSortQuery(query.orderBy)); | |||
|
|
|||
| if (this._parentId) { | |||
There was a problem hiding this comment.
In the syncfusion front-end, the executeApi is more complex and with more parameters. Why can't we do this here? Why can't parentId be an optional parameter to pass to executeApi instead of being passed in the ctor?
| @@ -4,9 +4,11 @@ import type { Query, OrderBy } from "@js/grids/vuetify/types"; | |||
|
|
|||
| export class DataAdaptor extends ObApiClient { | |||
| private readonly errorCallback: Function; | |||
| private readonly _parentId?: string; | |||
There was a problem hiding this comment.
The underscore for private fields is an outdated convention...
It should be used only in case of possible member conflict:
https://stackoverflow.com/questions/47747809/typescript-underscore-convention-for-members
https://www.typescriptlang.org/docs/handbook/2/classes.html#private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should allow parentId by default on our grids so that if you're needing to grab data with a parentId filter..
We already provide a parentId in our API but never added it as a query parameter.
Should look something like this:
Description
Added the ability to use parentId in UI
Motivation and Context
Solves API being allowed to use parentId query parameter but Vuetify / Obelisk UI by default not having a parentId