Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic AWS SES Implementation #77

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

dcsl-alexis
Copy link

Recently implemented email sending via SES on a project - contributing this back for future use in Obelisk based projects.

Copy link
Contributor

@nickskliar-davies nickskliar-davies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General Question - does this not require some sort of API Key?

@nickskliar-davies
Copy link
Contributor

Also - can you have a look at the SendGrid implementation for "enforced emails" they're a bit more complicated these days (and at some point I may add the extra complexity that I added into Buynex.....

@dcsl-alexis
Copy link
Author

General Question - does this not require some sort of API Key?

No. When running on AWS infra, it relies on IAM grants to be allowed to talk to SES. If you're running locally, then it utilises SSO via the AWSSDK (which you configure a profile setting in a particular appsettings key)

@dcsl-alexis dcsl-alexis reopened this Dec 12, 2024
@dcsl-alexis
Copy link
Author

@nickskliar-davies you can also it seems pass in general AWS Access Key and Secret in addition to the SSO/verified role identity etc. Not sure whether we need to support that or not.

@nickskliar-davies
Copy link
Contributor

@nickskliar-davies you can also it seems pass in general AWS Access Key and Secret in addition to the SSO/verified role identity etc. Not sure whether we need to support that or not.

@dcsl-alexis I mean, in an ideal world yes, but if that's more work than you have time for, use a docstring or something to say we only support the integrated auth OWTTE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants