Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Dockerization #65

Merged
merged 3 commits into from
Jan 29, 2024
Merged

FEAT: Dockerization #65

merged 3 commits into from
Jan 29, 2024

Conversation

CesarD
Copy link
Collaborator

@CesarD CesarD commented Jan 26, 2024

Description

Add the required configurations for dockerizing the project and be able to both publish it into a container image and run it and debug it in a container.

Related Issue

Closes #26

Motivation and Context

As explained in #26, this will help offering support for containers, publish images and debugging capabilities on them out-of-the-box.

How Has This Been Tested?

API project can now be ran and debugged on a container straight from VS and an image be built straight from the dotnet CLI due to the SDK Container configuration.
A note to consider: current mechanism (SDK Container) is only supported for debugging from VS 2022 v17.9 (currently in Preview).
For publishing the project into an image is enough to run the following command:

dotnet publish /p:PublishProfile=DefaultContainer

This of course does not depend on VS versions.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CesarD CesarD added the enhancement New feature or request label Jan 26, 2024
Copy link
Collaborator

@Gonzo345 Gonzo345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@CesarD CesarD merged commit 2a34ad7 into main Jan 29, 2024
@CesarD CesarD deleted the feat/dockerize branch January 29, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE: Dockerization
3 participants