Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Dockerization #26

Closed
CesarD opened this issue Dec 19, 2022 · 0 comments · Fixed by #65
Closed

FEATURE: Dockerization #26

CesarD opened this issue Dec 19, 2022 · 0 comments · Fixed by #65
Assignees
@CesarD
Labels
enhancement New feature or request

Comments

@CesarD
Copy link
Collaborator

CesarD commented Dec 19, 2022 •
edited
Loading

Detailed Description

Include Docker configuration in the solution for the corresponding projects.

Context

This will help to offer the possibility of support containers such as Docker straight from the solution generation, without the developers having to implement it on their own afterwards.
It might also be very useful for later implementing the .NET Aspire integration from #55.

Possible Implementation

We can leverage the newly added native support for Containers by the .NET team: https://github.com/dotnet/sdk-container-builds/blob/main/README.md.
@CesarD CesarD added the enhancement New feature or request label Nov 29, 2023
@CesarD CesarD mentioned this issue Dec 6, 2023
Open
@CesarD CesarD self-assigned this Jan 18, 2024
@CesarD CesarD changed the title Dockerization FEATURE: Dockerization Jan 19, 2024
@CesarD CesarD mentioned this issue Jan 26, 2024
Merged
9 tasks
CesarD added a commit that referenced this issue Jan 29, 2024
@CesarD
FEAT: Dockerization (#65)
2a34ad7 
## Description
Add the required configurations for dockerizing the project and be able
to both publish it into a container image and run it and debug it in a
container.

## Related Issue
Closes #26 

## Motivation and Context
As explained in #26, this will help offering support for containers,
publish images and debugging capabilities on them out-of-the-box.

## How Has This Been Tested?
API project can now be ran and debugged on a container straight from VS
and an image be built straight from the dotnet CLI due to the SDK
Container configuration.
A note to consider: current mechanism (SDK Container) is only supported
for debugging from VS 2022 v17.9 (currently in Preview).
For publishing the project into an image is enough to run the following
command:
```
dotnet publish /p:PublishProfile=DefaultContainer
```
This of course does not depend on VS versions.

## Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

## Checklist:
- [X] My code follows the code style of this project.
- [X] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [X] I have read the **CONTRIBUTING** document.
- [ ] I have added tests to cover my changes.
- [X] All new and existing tests passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CesarD CesarD

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FEAT: Dockerization onebeyond/monaco
1 participant
@CesarD