-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pagination of list entries #32
Conversation
b9fbc6a
to
9b0e0ef
Compare
@lincmba lets add some documentation on the READ ME |
@lincmba see my comment here #29 (comment) |
plugins/src/main/java/org/smartregister/fhir/gateway/plugins/SyncAccessDecision.java
Outdated
Show resolved
Hide resolved
plugins/src/main/java/org/smartregister/fhir/gateway/plugins/SyncAccessDecision.java
Outdated
Show resolved
Hide resolved
5fb275a
to
7956df7
Compare
Tested out the implementation, the pagination itself works 👍🏾 but the pagination links are not returned. Getting this as a response (tested with paginated count of 2): {
"resourceType": "Bundle",
"id": "04bc098a-5ab8-42bb-ab5f-f9a2198f3900",
"type": "batch-response",
"link": [
{
"relation": "self",
"url": "http://fhir-shared-stage-sync-hapi-fhir.opensrp.svc:8080/fhir"
}
],
"entry": [
{
"resource": {
"resourceType": "Group",
"id": "6f3980e0-d1d6-4a7a-a950-939f3ca7b301",
.... |
Additionally update the unit tests to verify that the (previous/next) pagination links are returned correctly (depending on provided _ count). Note, the base url should be the same one from the request that was made. |
a34c46d
to
322832a
Compare
- Add README documentation - Move Magic Strings to constants file - Add functionality to a separate use case of when `/List?_id` is used - Update Tests with these changes
322832a
to
894cca8
Compare
894cca8
to
8696c88
Compare
plugins/src/main/java/org/smartregister/fhir/gateway/plugins/BaseEndpoint.java
Outdated
Show resolved
Hide resolved
plugins/src/main/java/org/smartregister/fhir/gateway/plugins/BaseEndpoint.java
Outdated
Show resolved
Hide resolved
plugins/src/main/java/org/smartregister/fhir/gateway/plugins/SyncAccessDecision.java
Show resolved
Hide resolved
Make self link consistent with other pagination links
bac7e2a
to
605926d
Compare
plugins/src/main/java/org/smartregister/fhir/gateway/plugins/SyncAccessDecision.java
Outdated
Show resolved
Hide resolved
605926d
to
ea59d43
Compare
fixes #29
IMPORTANT: Where possible all PRs must be linked to a Github issue
Resolves [link to issue]
Engineer Checklist
bug fixes
mvn spotless:check
to check my code follows the project'sstyle guide
mvn clean test jacoco:report
to confirm the coverage reportwas generated at
plugins/target/site/jacoco/index.html
mvn clean package
right before creating this pull request.