9: Code cleanup and Addressing Test Debt - Adding Unit Tests for Custom Endpoints PractitionerDetails and LocationHierarchy #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndegwamartin
requested changes
Nov 15, 2023
There was a problem hiding this comment.
@rehammuzzamil I tried running the tests with report generation but that seems to no longer get generated correctly and we get 0% coverage. Could you please confirm on your end and investigate/fix before we merge?
|
- Remove Jupiter unit test dependency
ndegwamartin
force-pushed
the
9-fix-code-coverage
branch
from
5504d41 to
13f32d1
Compare
|
@rehammuzzamil I've fixed the issue with the code coverage reporting, apparently it was being caused by the Jupiter unit tests dependency introduced in the PR here. |
ndegwamartin
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9
IMPORTANT: Where possible all PRs must be linked to a Github issue
Resolves [link to issue]
Engineer Checklist
bug fixes
mvn spotless:checkto check my code follows the project'sstyle guide
mvn clean testto confirm all new and existing testspassed.
mvn clean packageright before creating this pull request.