Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FHIR Gateway Extensions enhancements #108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ndegwamartin
Copy link
Collaborator

IMPORTANT: Where possible all PRs must be linked to a Github issue

  • Fix REL cache by sync strategy bug
  • Refactor LocationHierarchyHelper pagination
  • Unit testing
  • Release 2.2.4

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for
    bug fixes
  • I have added documentation for any new feature(s) and configuration
    option(s) on the README.md
  • I have run mvn spotless:check to check my code follows the project's
    style guide
  • I have run mvn clean test jacoco:report to confirm the coverage report
    was generated at plugins/target/site/jacoco/index.html
  • I ran mvn clean package right before creating this pull request.

- Fix REL cache by sync strategy bug
- Refactor LocationHierarchyHelper pagination
- Unit testing
- Release 2.2.4
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 55.07246% with 31 lines in your changes missing coverage. Please review.

Project coverage is 62.92%. Comparing base (3471eb3) to head (bd0022a).

Files with missing lines Patch % Lines
.../fhir/gateway/plugins/PermissionAccessChecker.java 25.00% 23 Missing and 1 partial ⚠️
.../org/smartregister/fhir/gateway/plugins/Utils.java 80.55% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #108      +/-   ##
============================================
+ Coverage     61.34%   62.92%   +1.58%     
- Complexity      208      219      +11     
============================================
  Files            16       16              
  Lines          1428     1454      +26     
  Branches        165      166       +1     
============================================
+ Hits            876      915      +39     
+ Misses          467      452      -15     
- Partials         85       87       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant