Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ona custom changes #2

Open
wants to merge 65 commits into
base: master
Choose a base branch
from
Open

Ona custom changes #2

wants to merge 65 commits into from

Conversation

FrankApiyo
Copy link
Member

No description provided.

@FrankApiyo FrankApiyo force-pushed the ona-custom-changes branch 2 times, most recently from 2187ba4 to b740c9d Compare December 14, 2022 06:31
@FrankApiyo FrankApiyo force-pushed the ona-custom-changes branch 3 times, most recently from 2bb13a6 to 0325aff Compare December 14, 2022 06:42
index.js Outdated
}
})
.catch((error) => {
console.log(error)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

index.js Outdated
} else if ("/health-check" == req.url) {
done()
} else {
done("Authentication Failure");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add a status code (401)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find how to do this from fastify documentation

index.js Outdated
.then(fastify => // LAUNCH SERVER
fastify.listen({ port: process.env.SERVER_PORT || 3000, host: process.env.SERVER_HOST || '0.0.0.0' }, (err, address) => {
if (err) {
console.log(err)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

}
console.info(`Server listening on ${address}`)
}))
.catch(console.log)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we maybe add the error to logs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If t this error occurs, most likely we didn't import fastify successfully and so the logger has not been initialized

@FrankApiyo FrankApiyo force-pushed the ona-custom-changes branch from cef99bc to 8bd36bb Compare May 11, 2023 08:26
FrankApiyo and others added 30 commits May 13, 2024 20:07
Update base image to node:20.15.0-alpine3.19
Update base image to node:20.15.1-alpine3.20
Remove express and upgrade node version
Update find-my-way 8.0.0 -> 8.2.2
Change CORS_ORIGIN -> CORS_ORIGINS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants