-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ona custom changes #2
base: master
Are you sure you want to change the base?
Conversation
2187ba4
to
b740c9d
Compare
2bb13a6
to
0325aff
Compare
0325aff
to
9ac5039
Compare
2f57741
to
db113da
Compare
index.js
Outdated
} | ||
}) | ||
.catch((error) => { | ||
console.log(error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
index.js
Outdated
} else if ("/health-check" == req.url) { | ||
done() | ||
} else { | ||
done("Authentication Failure"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add a status code (401)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find how to do this from fastify documentation
index.js
Outdated
.then(fastify => // LAUNCH SERVER | ||
fastify.listen({ port: process.env.SERVER_PORT || 3000, host: process.env.SERVER_HOST || '0.0.0.0' }, (err, address) => { | ||
if (err) { | ||
console.log(err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
} | ||
console.info(`Server listening on ${address}`) | ||
})) | ||
.catch(console.log) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we maybe add the error to logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If t this error occurs, most likely we didn't import fastify successfully and so the logger has not been initialized
cef99bc
to
8bd36bb
Compare
Optimive mvt query
Use node:20.13.1-alpine3.19
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Update base image to node:20.15.0-alpine3.19
Update base image to node:20.15.1-alpine3.20
Get map bounds
Update axios to v1.7.5
Remove express and upgrade node version
Update find-my-way 8.0.0 -> 8.2.2
Oct 30 2024 sec updates
Update cross-spawn
Update package-lock file
Change CORS_ORIGIN -> CORS_ORIGINS
No description provided.