Gonza #53
Merged
Gonza #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
GonzzaG
commented
Sep 18, 2024
GonzzaG
commented
- fixed bug in serializer of InferenceExperiments
- fixed bug in the models of StatisticalValidation sources
- fixed bug in the models of StatisticalValidation sources
Genarito
reviewed
Sep 18, 2024
src/statistical_properties/models.py
Outdated
| @@ -148,13 +148,13 @@ class StatisticalValidation(models.Model): | |||
| related_name='statistical_validations', null=True, blank=True) | |||
|
|
|||
| # Sources | |||
| mrna_source_result = models.OneToOneField('StatisticalValidationSourceResult', on_delete=models.CASCADE, null=True, | |||
| mrna_source_result = models.OneToOneField('api_service.ExperimentClinicalSource', on_delete=models.CASCADE, null=True, | |||
There was a problem hiding this comment.
Ojo, volvé todos estos campos a como estaban. Acá estás cambiando la tabla a la que apuntan. El problema que teníamos solo debía resolverse en el serializer ya que era solo un problema de cómo se representaban los datos para mandarlo al frontend, no es un problema sobre cómo se almacenan.
Otra cosa, cuando se editan los models.py hay que correr el comando python3 manage.py makemigrations y python3 manage.py migrate para que se creen las migraciones que aplican los cambios en la DB física (postgres) y el otro para que se apliquen dichas migraciones. Acá estás modificando el modelo, pero no aplicás los cambios en la DB porque lo que va a terminar fallando después.
…ethod to retrieve experiments shared with user or their institution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.