Run PixelDataThread Application Events in SYSTEM Thread Pool #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jburel I updated |
jburel
reviewed
Feb 24, 2023
build.gradle
Outdated
| @@ -5,7 +5,7 @@ plugins { | |||
| } | |||
|
|
|||
| group = "org.openmicroscopy" | |||
| version = "5.6.6-SNAPSHOT" | |||
There was a problem hiding this comment.
This is not needed.
This will be changed post release
|
Regarding the comment on ome/omero-documentation#2292 (comment) |
joshmoore
approved these changes
Mar 1, 2023
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/scaling-up-pyramid-generation-in-omero-server/81041/2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154. As outlined in the issue, the thread pool that is used for
USERandBACKGROUNDpriority tasks is the same and is set up with an unbounded queue. Because of this, the maximum number of threads that can be active at one time is whatever the core pool size is set to - in this caseminThreads. Having any limit on the maximum number of threads is an issue if you have dependent tasks, which we do. In this PR, we change the application event tasks to be run atSYSTEMpriority, which means they are run in a different, unbounded thread pool. This way, these tasks will never be blocked by the dependent tasks, preventing deadlock. Javadocs were also added to explain what theThreadPoolconstructor parameters actually do.