Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update #214

Merged
merged 21 commits into from
Feb 5, 2024
Merged

Update #214

merged 21 commits into from
Feb 5, 2024

Conversation

jburel
Copy link
Member

@jburel jburel commented Jan 9, 2024

  • Update the version of actions
  • Test with updated test infra

@jburel jburel mentioned this pull request Jan 10, 2024
Merged
@jburel jburel force-pushed the update branch 3 times, most recently from 42bf629 to 4ed5b44 Compare January 11, 2024 07:32
This was referenced Feb 1, 2024
Closed
Closed
@will-moore
Copy link
Member

@jburel This PR should fix the font.getsize() issue reported by @juliomateoslangerak at ome/omero-figure#522 (comment)

@jburel
Copy link
Member Author

jburel commented Feb 1, 2024 •
edited
Loading

@will-moore I add to disable the test_move_annotations test for now. It failed for wells.
I would suggest that we integrate the set of the changes in this PR after review then fix the test in a follow up PR since it is blocking other work

@jburel jburel requested a review from will-moore February 1, 2024 17:12
will-moore
will-moore approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. Tested Split-View Figure on merge-ci and it fixes the font.getsize() error and works OK. 👍

@jburel jburel merged commit 4e04dc4 into ome:develop Feb 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbesson sbesson sbesson left review comments

@will-moore will-moore will-moore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jburel @will-moore @sbesson