Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin version to match rtd ones #2347

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

jburel
Copy link
Member

@jburel jburel commented Sep 13, 2023

The requirements file is used by merge-ci job
this PR pins the requirements so it matches the version used on rtd

--exclude

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning the versions in the requirements file is definitely one way to fixes the mismatch between the readthedocs build environment and the OME Jenkins CI build environment. Additionally, this meets the recommendations of the readthedocs guide and should reduce the occasional cases of failures associated with upstream releases containing backward-incompatible changes.

No objection from my side to the fix. Note this raises a few wider policy questions that will need to be decided by the docs maintainers:
1- does the same policy need be enforced across the 20+ RTD projects owned by OME?
2- should these requirements files be periodically reviewed and updated?

@jburel
Copy link
Member Author

jburel commented Sep 13, 2023

We have to review the repositories in order to make sure we have the correct version of the config file so the pinning can occur at the same time
A review will need to happen at regular intervals

@jburel
Copy link
Member Author

jburel commented Sep 14, 2023

it requires Python 3.9
This is the error on merge-ci (python 3.8 is installed)

Ignored the following versions that require a different python version: 7.2.0 Requires-Python >=3.9; 7.2.1 Requires-Python >=3.9; 7.2.2 Requires-Python >=3.9; 7.2.3 Requires-Python >=3.9; 7.2.4 Requires-Python >=3.9; 7.2.5 Requires-Python >=3.9; 7.2.6 Requires-Python >=3.9

@jburel
Copy link
Member Author

jburel commented Sep 15, 2023

--exclude

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants