-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin version to match rtd ones #2347
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinning the versions in the requirements file is definitely one way to fixes the mismatch between the readthedocs build environment and the OME Jenkins CI build environment. Additionally, this meets the recommendations of the readthedocs guide and should reduce the occasional cases of failures associated with upstream releases containing backward-incompatible changes.
No objection from my side to the fix. Note this raises a few wider policy questions that will need to be decided by the docs maintainers:
1- does the same policy need be enforced across the 20+ RTD projects owned by OME?
2- should these requirements files be periodically reviewed and updated?
We have to review the repositories in order to make sure we have the correct version of the config file so the pinning can occur at the same time |
it requires Python 3.9
|
--exclude |
The requirements file is used by merge-ci job
this PR pins the requirements so it matches the version used on rtd
--exclude