-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matlab Examples #127
Matlab Examples #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should that be a completely separate workflow? There is no relationship to the Java source code and/or the Maven/Ant build system so introducing this as tasks is a bit artificial.
Also, there is no real reason to run these tests for each JDK version since only the JDK of the Docker image should matter
I was thinking to add a new workflow. I put there for convenience for initial review |
@sbesson matlab tests now run in separate workflow. |
From https://github.com/ome/bio-formats-examples/actions/runs/8619991128/job/23625881927?pr=127
|
Thanks. I think we have again a similar problem I had on the octave repo with false positive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still running into runtime failures
warning: function ./test.m shadows a core library function
error: 'bfCheckJavaPath' undefined near line 1 column 1
error: called from
/src/main/matlab/bftest.m at line 1 column 1
Thanks. I think we have again a similar problem I had on the octave repo with false positive
Yes the inability to get a failed status above is not great. Going one step further, this makes me consider whether it is valuable to invest in this work at all if we are unable to flag failures as this defies the point of these workflows in the first place. I don't know if the issue lies with GNU Octave, the Docker infrastructure or the way the file is executed.
I will have to check |
This PR is built on top of #126 to avoid conflicts.This PR allows to run the matlab examples on MacOS and Ubuntu using the bf-octave docker image
It takes longer to run the test on Mac since docker needs to be installed.
I can close #126 if we prefer to combine everything in one PR