feat: search range of verses #409
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whiskydog
force-pushed
the
search-range-of-verses
branch
from
2a13089 to
2a36b5d
Compare
Whiskydog
force-pushed
the
search-range-of-verses
branch
from
2a36b5d to
f5971de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added functionality for the searching of a range of verses in its separate route handler. Also implemented its tests and documented it accordingly.
Motivation or Context
It resolves issue #35
How Has This Been Tested?
I implemented the relevant tests in the
verse.test.jsfile checking for the pertaining edge cases that I saw fit. However feel free to point out any testing that I left out. I realized the tests using Docker containers on Windows; all green.Types of changes
Checklist: