Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing interface options #77

Merged
merged 3 commits into from
May 9, 2024
Merged

fix: add missing interface options #77

merged 3 commits into from
May 9, 2024

Conversation

saul-jb
Copy link
Collaborator

@saul-jb saul-jb commented Apr 25, 2024

This PR adds the following missing options to the Options interface.

  • num_gpu
  • num_gqa
  • rope_frequency_base
  • rope_frequency_scale

See https://github.com/ollama/ollama/blob/main/docs/api.md#request-6

@saul-jb saul-jb requested a review from BruceMacD April 25, 2024 04:13
BruceMacD
BruceMacD approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@BruceMacD BruceMacD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, some of them will be deprecated soon but num_gpu should be available.

src/interfaces.ts Outdated Show resolved Hide resolved
src/interfaces.ts Outdated Show resolved Hide resolved
@BruceMacD BruceMacD merged commit a0b47fe into ollama:main May 9, 2024
3 checks passed
@paulsybrandy paulsybrandy mentioned this pull request Jul 7, 2024
Open
@andyshand andyshand mentioned this pull request Aug 29, 2024
Open
@PierreGode PierreGode mentioned this pull request Sep 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BruceMacD BruceMacD BruceMacD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saul-jb @BruceMacD