Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support webp & avif images #167

Closed

Conversation

lifeart
Copy link
Contributor

@lifeart lifeart commented Nov 29, 2024

Added support for additional image formats: avif, svg, gif, webp.

To test it properly I have to replace jest with vitest (for proper esmodules support).

Linters and formatters applyed.

@ParthSareen
Copy link
Contributor

Hi @lifeart! Happy to look at this 😄 Would it be possible to keep the diff minimal? I think this is one case where we shouldn't apply the linters and formatters just yet if we want to get this in. Thanks and appreciate the contribution!

@lifeart
Copy link
Contributor Author

lifeart commented Dec 5, 2024

Hi @ParthSareen, thank you for feedback!
I would try to split PR to smaller changes:

  1. Replacing jest with vitest (better performance, native es modules support, without extra transformations) refactor: replace jest with vitest #173
  2. Once landed, I will create PR with this feature (and tests for it) feature: WebP images support #174
  3. Once landed, I could create PR with linting & formatters fixes. chore: support typescript checking in tests #175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants