Improve responsiveness of app launches #1311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, I appreciate the effort. I agree that this should be improved, but I disagree with the implementation. I think the direction of dependencies is bad. The action handlers should not know anything about browser windows. Every future action handler needs to implement this again, and this is a bad design in my opinion. Here is how I would do it: #1312 |
|
Totally agree my implementation felt a bit off while writing it that makes way more sense thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pressing enter on an item if the app is slow to launch it feels like nothing happened as ueli doesnt show any feedback this pr makes it so that ueli hides itself while launching the app if the app errors it will reappear