Add settings window resize #1212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Although I appreciate your efforts I think that this is not the best solution to the problem. I think what we really need is having the settings in a completely separate window. See #1119 |
|
All good was just messing around with some stuff 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to have different sized windows when in the settings window vs normal also added a setting to configure the sizes of them by default.
Some css changes might be a good idea as rn there is a slight amount of lag to the ui changing as it resizes maybe just set the whole screen to the background color temporarly and hide all the ui or do some fading not to sure.
This helps fix alot of the settings UI bugs where buttons and dropdowns are squashed or overflowing kinda of a patch to that bug but I plan on fixing that properly soon but this was a small addition that I extracted while messing around with that idea.