forked from PHPOffice/PhpSpreadsheet
-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix PHPOffice#4192. Although that issue can be dealt with by changing user code, it would be better to fix it within PhpSpreadsheet. A cloned worksheet may have a pointer to a spreadsheet to which it is not attached. Code can assume it does belong to the spreadsheet, and throw an exception when the spreadsheet cannot find the worksheet in question. It may also not throw an exception when it should. In my comments to the issue, I was concerned that adding in the needed protection would add overhead to an extremely common situation (setting a cell's value) in order to avoid a pretty rare problem. However, there are problems with both the accuracy and efficiency of the existing code, and I think any performance losses caused by the additional checks will be offset by the performance gains and accuracy of the new code. Spreadsheet `getIndex` attempts to find the index of a worksheet within its spreadsheet collection. It does so by comparing the hash codes of each sheet in its collection with the hash code of the sheet it is looking for. Its major problem problem is performance-related, namely that it recomputes the hash code of the target sheet with each iteration. A more severe problem is the accuracy of the hash code. It generates this by hashing together the sheet title, the string range of its auto-filter, and a character representation of whether sheet protection is enabled. Title should definitely be part of the calculation (it must be unique for all sheets attached to a spreadsheet), but it is not clear why this subset of the other properties of Worksheet is used. It tries to save some cycles by using a `dirty` property to indicate whether re-hashing is necessary. It sets that property whenever the title changes, or when `setProtection` is called. So, it doesn't set it when auto-filter changes, and you can easily bypass `setProtection` when changing any of the `Protection` properties. Not to mention the many other properties of worksheet that can be changed. Additionally, if you clone a worksheet, the clone and the original will have the same hash code, which can lead to problems: ```php $clone = clone $original; $spreadsheet->getSheet($spreadsheet->getIndex($clone)) ->setCellValue('A1', 100); ``` That code will change the value of A1 in the original, not the clone. The `hash` property in Worksheet will now be calculated immediately when the object is constructed or cloned or unserialized. It will not be recalculated, and there is no longer a need for the `dirty` property, which is removed. Hash will be generated by spl_object_id, which was designed for this purpose. (So was spl_object_hash, but many online references suggest that \_id performs much better than \_hash.) Our problem example above will now throw an Exception, as it should, rather than changing the wrong cell. `setValueExplicit`, the problem in the original issue, will now test that the worksheet is attached to the spreadsheet before doing any style manipulation. In order that this not be a breaking change, `getHashCode` will continue to return string, but it is deprecated in favor of `getHashInt`, and Worksheet will no longer implement IComparable to facilitate the deprecation. I had a vague hope that this change might help with issue PHPOffice#641. It doesn't.
- Loading branch information
Showing
6 changed files
with
92 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace PhpOffice\PhpSpreadsheetTests\Worksheet; | ||
|
|
||
| use PhpOffice\PhpSpreadsheet\Exception as SpreadsheetException; | ||
| use PhpOffice\PhpSpreadsheet\Spreadsheet; | ||
| use PhpOffice\PhpSpreadsheet\Worksheet\Worksheet; | ||
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| class CloneTest extends TestCase | ||
| { | ||
| public function testUnattachedIndex(): void | ||
| { | ||
| $spreadsheet = new Spreadsheet(); | ||
| $sheet1 = $spreadsheet->getActiveSheet(); | ||
| $sheet1->getCell('A1')->setValue(10); | ||
| $sheet2 = clone $sheet1; | ||
| $sheet2->getCell('A1')->setValue(20); | ||
| self::assertSame(0, $spreadsheet->getIndex($sheet1)); | ||
| $idx = $spreadsheet->getIndex($sheet2, true); | ||
| self::assertSame(-1, $idx); | ||
| $sheet2->setTitle('clone'); | ||
| $spreadsheet->addSheet($sheet2); | ||
| $idx = $spreadsheet->getIndex($sheet2, true); | ||
| self::assertSame(1, $idx); | ||
| self::assertSame(10, $spreadsheet->getSheet(0)->getCell('A1')->getValue()); | ||
| self::assertSame(20, $spreadsheet->getSheet(1)->getCell('A1')->getValue()); | ||
| $spreadsheet->disconnectWorksheets(); | ||
| } | ||
|
|
||
| public function testGetCloneIndex(): void | ||
| { | ||
| $this->expectException(SpreadsheetException::class); | ||
| $this->expectExceptionMessage('Sheet does not exist'); | ||
| $spreadsheet = new Spreadsheet(); | ||
| $sheet1 = $spreadsheet->getActiveSheet(); | ||
| $sheet1->getCell('A1')->setValue(10); | ||
| $sheet2 = clone $sheet1; | ||
| $spreadsheet->getSheet($spreadsheet->getIndex($sheet2)) | ||
| ->setCellValue('A1', 100); | ||
| } | ||
|
|
||
| public function testSerialize1(): void | ||
| { | ||
| // If worksheet attached to spreadsheet, can't serialize it. | ||
| $this->expectException(SpreadsheetException::class); | ||
| $this->expectExceptionMessage('cannot be serialized'); | ||
| $spreadsheet = new Spreadsheet(); | ||
| $sheet1 = $spreadsheet->getActiveSheet(); | ||
| serialize($sheet1); | ||
| } | ||
|
|
||
| #[\PHPUnit\Framework\Attributes\RunInSeparateProcess] | ||
| public function testSerialize2(): void | ||
| { | ||
| $sheet1 = new Worksheet(); | ||
| $sheet1->getCell('A1')->setValue(10); | ||
| $serialized = serialize($sheet1); | ||
| /** @var Worksheet */ | ||
| $newSheet = unserialize($serialized); | ||
| self::assertSame(10, $newSheet->getCell('A1')->getValue()); | ||
| self::assertNotEquals($newSheet->getHashInt(), $sheet1->getHashInt()); | ||
| } | ||
| } |