Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OKTA-729786: add snyk scan #413

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

bryanapellanes-okta
Copy link
Contributor

No description provided.

bretterer
bretterer previously approved these changes Jul 8, 2024
Copy link
Collaborator

@bretterer bretterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @bryanapellanes-okta

Go ahead and merge

@@ -3,6 +3,7 @@ version: 2.1

orbs:
python: circleci/[email protected]
platform-helpers-general: <org>/eng-services-platform-helpers-general@2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bretterer Looking at this I think <org> should probably be replaced by either atko-eng or atko-eng-services per step 2 in the "Implementing Dependency Scanning - CircleCI " section of this doc: https://oktawiki.atlassian.net/wiki/spaces/REX/pages/2765043690/Dependency+Scanning+-+Self-Service+Wiki#Implementing-Dependency-Scanning---CircleCI

It isn't clear to me which to use.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per internal comment the correct value is probably okta

@bryanapellanes-okta bryanapellanes-okta force-pushed the OKTA-729786-add-snyk-scan branch 3 times, most recently from a1efc03 to 79e9556 Compare July 15, 2024 16:13
@bryanapellanes-okta bryanapellanes-okta force-pushed the OKTA-729786-add-snyk-scan branch from 79e9556 to 5a808cf Compare July 15, 2024 16:17
@bryanapellanes-okta bryanapellanes-okta merged commit 7ffe66f into master Jul 15, 2024
5 of 6 checks passed
@bryanapellanes-okta bryanapellanes-okta deleted the OKTA-729786-add-snyk-scan branch July 15, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants