-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UUID representation for ULID type #92
Open
elipavlov
wants to merge
1
commit into
oklog:main
Choose a base branch
from
elipavlov:feature/uuid-repr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this is a bit ambiguous. First, "UUID string" is I think not sufficiently qualified — the specific format implemented in this PR I think has a more precise name? Second, if the tool can output UUIDs, then I would expect it could also input UUIDs, i.e. I would expect that
would parse to the same thing? So like if we do this then
--uuid
should I guess not be just an expression of output format but also should be able to control parse behavior. Which gets tricky!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can speak about UUID format, considering ULID library and CLI tool. I'm talking about that:
https://en.wikipedia.org/wiki/Universally_unique_identifier#Format
Yes, there are five (existing) different versions of UUID.
But, my point is that ULID interoperability with UUID should only work with the format, and leave UUID version interpretation to the users' code.
I agree 100%.
Here I wanted to solve only my particular use-case "generate uuids by ulids".
I will consider this point closer ant try to provide some solution for parsing UUIDs
As for tests - OK, it's not a problem.
As for ambiguity - I rather agree, but i couldn't come up with better flag naming. If you have some thoughts please share them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4] Ambiguity. My first thought was to add one more variant to the
--format
flag, but when I looked it closer, I'd figured that the--format
flag works with the dates, and also in the parsing function. I'd decided to leave it as is and made another flag.