Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed alignment of components in mobile view #10038

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

manmeetnagii
Copy link
Contributor

@manmeetnagii manmeetnagii commented Jan 18, 2025

Proposed Changes

Screenshot 2025-01-18 095024

Screenshot 2025-01-18 090935

Screenshot 2025-01-18 092032

Screenshot 2025-01-18 092502

@ohcnetwork/care-fe-code-reviewers

Summary by CodeRabbit

  • Style
    • Updated login form container styling to adjust element alignment and responsiveness.

@manmeetnagii manmeetnagii requested a review from a team as a code owner January 18, 2025 02:44
Copy link
Contributor

coderabbitai bot commented Jan 18, 2025

Walkthrough

The pull request includes several modifications across multiple components, primarily focusing on CSS class adjustments to improve layout and responsiveness. Changes were made to the Login.tsx, PatientDetailsTab, PatientHome, PatientIndex, ResourceCreate, and AppointmentTokenCard components, enhancing the user interface without altering the underlying functionality.

Changes

File Change Summary
src/components/Auth/Login.tsx Modified div className from "relative h-full items-center justify-center md:flex" to "relative h-full items-center flex justify-center md:flex"
public/locale/en.json Added new key "not_found": "Not Found" for localization support.
src/components/Patient/PatientDetailsTab/patientUpdates.tsx Changed displayed message from {t("no_updates_found")} to {t("no_update_available")}.
src/components/Patient/PatientHome.tsx Removed mx-3 class from div, affecting horizontal margin.
src/components/Patient/PatientIndex.tsx Added mb-2 class to the "verify" button for bottom margin.
src/components/Resource/ResourceCreate.tsx Changed layout class to flex-col lg:flex-row gap-2 lg:items-center for responsive design.
src/pages/Appointments/components/AppointmentTokenCard.tsx Updated classNames for responsive width and background image size adjustments.

Assessment against linked issues

Objective Addressed Explanation
Center login form in mobile view [#10037]
Adjust layout for better alignment in mobile view [#10037]

Possibly related PRs

Suggested labels

needs review, tested

Suggested reviewers

  • rithviknishad
  • Jacobjeevan

Poem

🐰 A rabbit's tale of CSS delight,
Where classes dance and pixels align just right,
One tweak, one flex, a mobile view so neat,
Login form centered, now perfectly sweet!
Code magic happens in just one line 🔧


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 11e9b79 and 71444ae.

📒 Files selected for processing (6)
  • public/locale/en.json (1 hunks)
  • src/components/Patient/PatientDetailsTab/patientUpdates.tsx (1 hunks)
  • src/components/Patient/PatientHome.tsx (1 hunks)
  • src/components/Patient/PatientIndex.tsx (1 hunks)
  • src/components/Resource/ResourceCreate.tsx (2 hunks)
  • src/pages/Appointments/components/AppointmentTokenCard.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • src/components/Patient/PatientIndex.tsx
  • src/components/Patient/PatientHome.tsx
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: cypress-run (1)
  • GitHub Check: OSSAR-Scan
🔇 Additional comments (4)
src/pages/Appointments/components/AppointmentTokenCard.tsx (1)

26-26: Well-structured responsive layout improvements!

The changes enhance the component's responsiveness and visual appeal:

  • Responsive width using lg:w-[30rem]
  • Adaptive background image sizing
  • Flexible layout for facility information
  • Smooth hover animations

Also applies to: 28-28, 36-39

src/components/Patient/PatientDetailsTab/patientUpdates.tsx (1)

44-44: Improved empty state message!

The text change provides a more user-friendly message when no updates are available.

src/components/Resource/ResourceCreate.tsx (1)

372-372: Improved form layout responsiveness!

The changes enhance the form's layout and spacing:

  • Responsive contact information header layout
  • Better visual separation for the phone number field

Also applies to: 421-421

public/locale/en.json (1)

1437-1437: Clean addition of translation key!

The new translation key follows the established format and maintains alphabetical ordering.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Jan 18, 2025

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 71444ae
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/678b2baece9e4d00085ad5d5
😎 Deploy Preview https://deploy-preview-10038--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@manmeetnagii manmeetnagii changed the title Fixed alignment of login form Fixed alignment of components in mobile view Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor Issue: Misalignment of Some Components in Mobile View
1 participant