Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Button Hover Color Problem in Requests Table Status Field #10034

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Resolve Button Hover Color Problem in Requests Table Status Field #10034

wants to merge 3 commits into from
+13 −5

Conversation

modamaan
Copy link
Contributor

@modamaan modamaan commented Jan 17, 2025 •
edited by coderabbitai bot
Loading

Proposed Changes

Before

loom-video.10.mp4

After

loom-video.11.mp4

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • Style
    • Enhanced resource request status badges with hover effects
    • Added interactive hover states for different status colors (Pending, Approved, Rejected, Completed)
    • Improved visual feedback for status badge interactions

@modamaan modamaan requested a review from a team as a code owner January 17, 2025 20:37
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 17, 2025 •
edited
Loading

Walkthrough

The pull request modifies the ResourceRequests component in the patient details tab, specifically enhancing the visual interaction of status badges. The changes focus on adding hover styles to the Badge component for resource request statuses. By introducing hover effects for PENDING, APPROVED, REJECTED, and COMPLETED statuses, as well as the default badge state, the component now provides improved visual feedback when users interact with status indicators.

Changes

File Change Summary
src/components/Patient/PatientDetailsTab/ResourceRequests.tsx - Added hover styles to PENDING, APPROVED, REJECTED, and COMPLETED status badges
- Extended default badge styling to include hover effects

Assessment against linked issues

Objective Addressed Explanation
Fix Button Hover Color Issue [#10033] ✅

Possibly related PRs

Suggested reviewers

  • rithviknishad

Poem

🐰 Hover badges, soft and bright,
Dancing colors, pure delight!
From gray to yellow, styles now gleam,
Interactive elements now supreme!
A rabbit's touch of UI dream 🎨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5dc5567 and e594373.

📒 Files selected for processing (1)
  • src/components/Patient/PatientDetailsTab/ResourceRequests.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/components/Patient/PatientDetailsTab/ResourceRequests.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify Netlify
Copy link

netlify bot commented Jan 17, 2025 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit d5a02b2
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/678bd173960e52000848d591
😎 Deploy Preview https://deploy-preview-10034--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai[bot]
coderabbitai bot reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
src/components/Patient/PatientDetailsTab/ResourceRequests.tsx (1)

43-56: Consider architectural improvements for maintainability.

A few suggestions to improve the code:

  1. Consider moving the color mappings to a theme configuration file for better maintainability and reusability.
  2. The status text should be translated using the t function, as other strings in the component are.

Example implementation:

// theme/status-colors.ts
export const statusColors = {
  PENDING: {
    base: "bg-yellow-100 text-yellow-800",
    hover: "hover:bg-yellow-200 hover:text-yellow-900",
  },
  // ... other statuses
};

// Component
<Badge
  className={
    (statusColors[status]?.base + " " + statusColors[status]?.hover) ||
    "bg-gray-100 text-gray-800 hover:bg-gray-200 hover:text-gray-900"
  }
>
  {t(`status.${status.toLowerCase()}`)}
</Badge>
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5c52b6 and 5dc5567.

📒 Files selected for processing (1)
  • src/components/Patient/PatientDetailsTab/ResourceRequests.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: Label linked issues
  • GitHub Check: Redirect rules - care-ohc
  • GitHub Check: Header rules - care-ohc
  • GitHub Check: Pages changed - care-ohc
  • GitHub Check: OSSAR-Scan
  • GitHub Check: CodeQL-Build
  • GitHub Check: cypress-run (1)
🔇 Additional comments (1)
src/components/Patient/PatientDetailsTab/ResourceRequests.tsx (1)

51-56: LGTM! Default badge styling maintains consistency.

The hover effect implementation for the default case follows the same pattern as the status-specific styles, ensuring a consistent user experience for any unknown status values.

src/components/Patient/PatientDetailsTab/ResourceRequests.tsx Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Button Hover Color Issue on Requests Table Status Field
1 participant
@modamaan