Typescript Support #137
Open
Typescript Support #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardchung
reviewed
Jun 17, 2023
| "build": "npm run build:patch && npm run build:data && npm run build:ts", | ||
| "build:ts": "rimraf dist && tsc --project tsconfig.json", | ||
| "build:data": "node tasks/updateconstants", | ||
| "build:patch": "node tasks/updateconstants" |
howardchung
reviewed
Jun 17, 2023
| region: require(__dirname + "/build/region.json"), | ||
| skillshots: require(__dirname + "/build/skillshots.json"), | ||
| xp_level: require(__dirname + "/build/xp_level.json") | ||
| abilities: require(__dirname + "/src/data/abilities.json"), |
There was a problem hiding this comment.
Do we need both this and the ts index file?
howardchung
reviewed
Jun 17, 2023
| @@ -36,7 +36,7 @@ const extraStrings = { | |||
| DOTA_UNIT_TARGET_HERO: "Hero", | |||
| DOTA_UNIT_TARGET_BASIC: "Basic", | |||
| DOTA_UNIT_TARGET_BUILDING: "Building", | |||
| DOTA_UNIT_TARGET_TREE: "Tree" | |||
| DOTA_UNIT_TARGET_TREE: "Tree", | |||
There was a problem hiding this comment.
I'd put the formatting only changes in a separate PR to make this easier to review
|
Looks like this combines the build and json directories into source files and outputs into dist? I feel like I'd miss the ability to diff the generated output since dist is gitignored |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Typescript support & Type Definitions for all dotaconstant values.