feat: estate #169
Open
feat: estate #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fres-sudo
force-pushed
the
18.0-tutorial-frca
branch
from
a21c051
to
4e7519c
Compare
proose
reviewed
Oct 25, 2024
estate/views/res_users_views.xml
Outdated
There was a problem hiding this comment.
Be careful that the list you show on the user allows to create a new line (so a new property), but it crashes. You can test that by going to the Settings app -> Users & Companies and selecting the user you are on (Mitchell Admin if you logged in with admin credentials) -> Real Estate properties
fres-sudo
force-pushed
the
18.0-tutorial-frca
branch
from
8e17a2f
to
15a3934
Compare
|
@fres-sudo Nicely done ! I see every comment I made were well corrected ! Last thing to do is to try to push your changes in one whole commit. Beware to only put your work in one commit, and not the work done by others before you. Tips: create a temporary branch before playing with your commits ( |
fres-sudo
force-pushed
the
18.0-tutorial-frca
branch
from
15a3934
to
94d5319
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frca