[ADD] 18.0 Estate module and Account Estate module - cove #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CorentinVermeulen
force-pushed
the
18.0-tutorial-cove
branch
from
8eb8c13
to
9475bc3
Compare
|
Ping Lucky you I'm your reviewer :D |
CorentinVermeulen
force-pushed
the
18.0-tutorial-cove
branch
from
99e7cbb
to
b526a96
Compare
CorentinVermeulen
force-pushed
the
18.0-tutorial-cove
branch
3 times, most recently
from
6b4a797
to
764c8f4
Compare
CorentinVermeulen
force-pushed
the
18.0-tutorial-cove
branch
from
dbadb67
to
b509c0d
Compare
CorentinVermeulen
force-pushed
the
18.0-tutorial-cove
branch
3 times, most recently
from
70fe0a5
to
822ef0d
Compare
aboo-odoo
reviewed
Oct 23, 2024
There was a problem hiding this comment.
Yo! first review for you ! Overall a extremely good work honestly. I've been extra picky and nitpicked a lot but honestly most of this is just styling stuff.
Two last comments I can make so far are:
- Could you rename your PR to something like [ADD] estate: a new module to manage estate properties and embellish a bit your description
- Mind that commit messages (and PR title) must be as followed [TAG] module(s): short description. The body of your commit message is as important as the title. I advice you to build that body use the following three sections:
1. Problem
2. Objective
3. Solution
and end your commit message with a reference to the task your assigned to (here there is none so you can put task-xxxxxx)
Check the commit message I pushed before on your branch for inspiration.
Once again, extremely good work. Keep it up 🥇
CorentinVermeulen
changed the title
CorentinVermeulen
force-pushed
the
18.0-tutorial-cove
branch
4 times, most recently
from
0f2a365
to
55f3dc2
Compare
CorentinVermeulen
force-pushed
the
18.0-tutorial-cove
branch
from
55f3dc2
to
8bd1a9e
Compare
CorentinVermeulen
force-pushed
the
18.0-tutorial-cove
branch
3 times, most recently
from
414bc7a
to
0ce6b18
Compare
1. Problem: None 2. Objective: - Finish the tutorial 101. Sometimes go a bit further (ex: smart button with invoice) - Make the necessary adjustement to have a nice code for the next code review. - Add some tests 3. Solution: Code and follow tutorial :) task-xxxxxxx
CorentinVermeulen
force-pushed
the
18.0-tutorial-cove
branch
from
9e042d0
to
cfd6dfb
Compare
CorentinVermeulen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.