[ADD] estate: a new module to manage estate properties #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lipiraux
force-pushed
the
18.0-tutorials-lipi
branch
from
95d5e12
to
8134c8b
Compare
|
Ping Lucky you I'm your reviewer :D |
aboo-odoo
force-pushed
the
18.0-tutorials-lipi
branch
from
8ba186d
to
8533f13
Compare
aboo-odoo
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Yo! first review for you ! Overall a extremely good work honestly. I've been extra picky and nitpicked a lot but honestly this is just styling stuff. Fundamentally, everything you did is correct.
Two last comments I can make so far are:
- Could you rename your PR to something like
[ADD] estate: a new module to manage estate propertiesand embellish a bit your description - Mind that commit messages (and PR title) must be as followed
[TAG] module(s): short description. The body of your commit message is as important as the title. I advice you to build that body use the following three sections:- Problem
- Objective
- Solution
and end your commit message with a reference to the task your assigned to (here there is none so you can put task-xxxxxx)
Check the commit message I pushed on your branch for inspiration.
Once again, extremely good work. Keep it up 🥇
lipiraux
changed the title
lipiraux
added a commit
to odoo-dev/tutorials
that referenced
this pull request
Oct 24, 2024
Problem --------- Users are missing a way to manage real estate properties in odoo. Objective --------- - Add a way to create new properties, track their attributes and the state of the sale (new, offer received, ..., sold). - Add a way to visualise and filter the properties base on their attributes and status. And give the user a way to categorize the properties. - Add a way to manage offer made by parters on individual properties. Be able to accept/refuse the offers. - Create an invoice to the client once a sale is closed. Solution --------- Add a new module `estate`. This model is in charge of managing the properties, tracking their sales state and offers. Add a new module `estate_account` to create invoices once a sale is closed. Closes odoo#162
lipiraux
force-pushed
the
18.0-tutorials-lipi
branch
from
0086d8d
to
3e3c474
Compare
Problem --------- Users are missing a way to manage real estate properties in odoo. Objective --------- - Add a way to create new properties, track their attributes and the state of the sale (new, offer received, ..., sold). - Add a way to visualise and filter the properties base on their attributes and status. And give the user a way to categorize the properties. - Add a way to manage offer made by parters on individual properties. Be able to accept/refuse the offers. - Create an invoice to the client once a sale is closed. Solution --------- Add a new module `estate`. This model is in charge of managing the properties, tracking their sales state and offers. Add a new module `estate_account` to create invoices once a sale is closed. Closes odoo#162
lipiraux
force-pushed
the
18.0-tutorials-lipi
branch
3 times, most recently
from
e368615
to
f46905a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.