Builder overlay #3501
Builder overlay #3501
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
sobo-odoo
force-pushed
the
master-mysterious-egg-sobo
branch
3 times, most recently
from
7417088
to
cdc50b5
Compare
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
FrancoisGe
force-pushed
the
master-mysterious-egg
branch
from
aeacbc1
to
395880e
Compare
sobo-odoo
force-pushed
the
master-mysterious-egg-sobo
branch
from
57ca2df
to
e5a0389
Compare
addons/html_builder/static/src/builder/plugins/builder_overlay/builder_overlay.js
Outdated
Show resolved
Hide resolved
addons/html_builder/static/src/builder/plugins/builder_overlay/builder_overlay_plugin.js
Outdated
Show resolved
Hide resolved
addons/html_builder/static/src/builder/plugins/builder_overlay/builder_overlay_plugin.js
Outdated
Show resolved
Hide resolved
addons/html_builder/static/src/builder/plugins/builder_overlay/builder_overlay_plugin.js
Outdated
Show resolved
Hide resolved
addons/html_builder/static/src/builder/plugins/builder_overlay/builder_overlay_plugin.js
Outdated
Show resolved
Hide resolved
addons/html_builder/static/src/builder/plugins/builder_overlay/builder_overlay_plugin.js
Show resolved
Hide resolved
| this.refreshPosition(); | ||
| this.refreshHandles(); |
There was a problem hiding this comment.
I would say that, for now, let's keep them separated: when the sizing,... will be implemented, we could still add an update function later to do both at once if we repeat them a lot 🙂
And if you meant "using the _update function of the plugin after calling toggleOverlay", then I prefer doing the refresh here, so the overlay logic is grouped at one place (easier to follow the flow), like each overlay updates itself 👍
| refreshHandles() { | ||
| this.overlays.forEach((overlay) => { | ||
| overlay.refreshHandles(); | ||
| }); | ||
| } |
There was a problem hiding this comment.
I prefer keeping everything separated, because we do not always need to update both at the same time, e.g.:
- scrolling only needs to refresh the position, as the handles are not supposed to change
- using an option may change both the size and the "status" of an element, so we need to refresh both the handles and the position
However, I agree that refreshHandles alone is not needed yet, but let's keep it for now to be consistent, we can remove it later if really no case needs it in the end 🙂
Also, the update was needed to use it in handleCommand, and also to make all the changes in one loop, to be a bit more efficient 🙂
| @@ -192,3 +192,9 @@ export function getScrollingElement(document = window.document) { | |||
| } | |||
| return baseScrollingElement; | |||
| } | |||
|
|
|||
| export function getScrollingTarget(contextItem = window.document) { | |||
There was a problem hiding this comment.
rename contextItem => scrollingElement
There was a problem hiding this comment.
document is not defined there, so we need to use window.document 🙂 (see the function just above that uses it too)
sobo-odoo
force-pushed
the
master-mysterious-egg-sobo
branch
from
e5a0389
to
318f42b
Compare
sobo-odoo
force-pushed
the
master-mysterious-egg-sobo
branch
from
318f42b
to
2b89573
Compare
|
I made the changes, see diff 🙂 (don't mind the |
No description provided.