[IMP] mysterious_egg #3474
Draft
[IMP] mysterious_egg #3474
+261
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:mysterious-egg, it needs to be retargeted before it can be merged. |
loco-odoo
force-pushed
the
mysterious-egg-2-loco
branch
5 times, most recently
from
da007fc
to
e81a630
Compare
loco-odoo
changed the base branch from
mysterious-egg
to
master-mysterious-egg
loco-odoo
force-pushed
the
mysterious-egg-2-loco
branch
9 times, most recently
from
6510625
to
c4b4364
Compare
FrancoisGe
reviewed
Nov 15, 2024
| @@ -24,7 +26,13 @@ export class SetupEditorPlugin extends Plugin { | |||
| .filter((el) => !el.hasAttribute("data-oe-sanitize-prevent-edition")); | |||
| editableEls.concat(Array.from(this.editable.querySelectorAll(".o_editable"))); | |||
| editableEls.forEach((el) => el.classList.add("o_editable")); | |||
| this.beforeUnloadFc = this.addDomListener(window, "beforeunload", (event) => { | |||
| if (this.isDirty()) { | |||
| event.returnValue = _t("This document is not saved!"); | |||
There was a problem hiding this comment.
document ? It s a strange name. Maybe "This website page is not saved!" ? Maybe check with lionel
addons/html_builder/static/src/builder/plugins/setup_editor_plugin.js
Outdated
Show resolved
Hide resolved
| this.initialUrl = `/website/force/${encodeURIComponent(this.backendWebsiteId)}`; | ||
| this.websiteService.currentWebsiteId = this.backendWebsiteId; |
There was a problem hiding this comment.
for another pr, websiteService life cycle ? Only when the editor is open ?
| this.getResource("handleNewRecords").forEach((cb) => cb(filteredRecords)); | ||
| // TODO modify `handleMutations` of web_studio to handle | ||
| // `undoOperation` | ||
| this.getResource("handleNewRecords").forEach((cb) => cb(filteredRecords, this.undoOperation)); |
There was a problem hiding this comment.
why not use the current step state ? I m not a big fan to put flag in this
| @@ -586,6 +589,7 @@ export class HistoryPlugin extends Plugin { | |||
| this.addStep({ stepState: "undo" }); | |||
| @@ -29,18 +29,21 @@ class WebsiteBuilder extends Component { | |||
| }); | |||
| this.state = useState({ isEditing: false }); | |||
| this.websiteService = useService("website"); | |||
| this.websiteService.useMysterious = true; | |||
|
|
||
| test("double click on Image", async () => { | ||
| await setupWebsiteBuilder(`<div><img class=a_nice_img src='${base64Img}'></div>`); | ||
| await openSnippetsMenu(); |
There was a problem hiding this comment.
check if you don t have .modal-content before. You don t have a specific class on your dialog ?
You have an issue in your test, if dblclick open another dialog for strange reason you don t know
FrancoisGe
reviewed
Nov 15, 2024
FrancoisGe
force-pushed
the
master-mysterious-egg
branch
from
aeacbc1
to
395880e
Compare
loco-odoo
force-pushed
the
mysterious-egg-2-loco
branch
6 times, most recently
from
12e0add
to
6af8375
Compare
loco-odoo
force-pushed
the
mysterious-egg-2-loco
branch
from
6af8375
to
e3c7fe5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begin of the save mechanism + tests