forked from misd-service-development/phone-number-bundle
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow Symfony 6 #96
Merged
Merged
allow Symfony 6 #96
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f4bd90a
add support for Symfony 6
dmaicher cc786e3
remove LegacyPhoneNumberNormalizerTrait
dmaicher a46a61b
revert PhoneNumberNormalizer changes
dmaicher aa38f51
require symfony/serializer ^6.0.1
dmaicher 43a6137
add return type hints to silence deprecation warnings
dmaicher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,8 +14,8 @@ | |
use libphonenumber\PhoneNumberUtil; | ||
use Misd\PhoneNumberBundle\Validator\Constraints\PhoneNumber; | ||
use Misd\PhoneNumberBundle\Validator\Constraints\PhoneNumberValidator; | ||
use PHPUnit\Framework\MockObject\MockObject; | ||
use PHPUnit\Framework\TestCase; | ||
use Prophecy\Argument; | ||
use Symfony\Component\Validator\Context\ExecutionContextInterface; | ||
use Symfony\Component\Validator\Exception\UnexpectedTypeException; | ||
use Symfony\Component\Validator\Mapping\ClassMetadata; | ||
|
@@ -28,7 +28,7 @@ | |
class PhoneNumberValidatorTest extends TestCase | ||
{ | ||
/** | ||
* @var \Symfony\Component\Validator\Context\ExecutionContextInterface|\PHPUnit_Framework_MockObject_MockObject | ||
* @var \Symfony\Component\Validator\Context\ExecutionContextInterface|MockObject | ||
*/ | ||
protected $context; | ||
|
||
|
@@ -39,12 +39,12 @@ class PhoneNumberValidatorTest extends TestCase | |
|
||
protected function setUp(): void | ||
{ | ||
$this->context = $this->prophesize(ExecutionContextInterface::class); | ||
$this->context = $this->createMock(ExecutionContextInterface::class); | ||
|
||
$this->validator = new PhoneNumberValidator(PhoneNumberUtil::getInstance()); | ||
$this->validator->initialize($this->context->reveal()); | ||
$this->validator->initialize($this->context); | ||
|
||
$this->context->getObject()->willReturn(new Foo()); | ||
$this->context->method('getObject')->willReturn(new Foo()); | ||
} | ||
|
||
/** | ||
|
@@ -67,14 +67,28 @@ public function testValidate($value, $violates, $type = null, $defaultRegion = n | |
} | ||
|
||
if (true === $violates) { | ||
$constraintViolationBuilder = $this->prophesize(ConstraintViolationBuilderInterface::class); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. rewritten because of phpspec/prophecy#527 |
||
$constraintViolationBuilder->setParameter(Argument::type('string'), Argument::type('string'))->willReturn($constraintViolationBuilder->reveal()); | ||
$constraintViolationBuilder->setCode(Argument::type('string'))->willReturn($constraintViolationBuilder->reveal()); | ||
$constraintViolationBuilder->addViolation()->willReturn($constraintViolationBuilder->reveal()); | ||
|
||
$this->context->buildViolation($constraint->getMessage())->shouldBeCalledTimes(1)->willReturn($constraintViolationBuilder->reveal()); | ||
$constraintViolationBuilder = $this->createMock(ConstraintViolationBuilderInterface::class); | ||
$constraintViolationBuilder | ||
->expects($this->exactly(2)) | ||
->method('setParameter') | ||
->with($this->isType('string'), $this->isType('string')) | ||
->willReturn($constraintViolationBuilder); | ||
$constraintViolationBuilder | ||
->expects($this->once()) | ||
->method('setCode') | ||
->with($this->isType('string')) | ||
->willReturn($constraintViolationBuilder); | ||
$constraintViolationBuilder | ||
->method('addViolation') | ||
->willReturn($constraintViolationBuilder); | ||
|
||
$this->context | ||
->expects($this->once()) | ||
->method('buildViolation') | ||
->with($constraint->getMessage()) | ||
->willReturn($constraintViolationBuilder); | ||
} else { | ||
$this->context->buildViolation()->shouldNotBeCalled(); | ||
$this->context->expects($this->never())->method('buildViolation'); | ||
} | ||
|
||
$this->validator->validate($value, $constraint); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stability requirement can be removed once Symfony 6.0.1 was released