make max array count I64_MAX #4674
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So only MacOS arm seems to be fine with this massive array. Linux and BSDs crash fail linking, Windows crashes, MacOS Intel gets stuck compiling or linking the program. |
|
Should figure out a max they all generally like and go with that. |
|
The original restriction was probably arbitrary but it was to prevent a few bugs in LLVM due to initialization issues. Large arrays in LLVM tend to make the entire thing go extremely slow. It's hard to replicate because it's been quite a long time now and I cannot remember the precise circumstances to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4658