Fix parsing of integer w/ 'e' notation #4580
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tf2spi
changed the title
|
Marked as draft b/c there may be other ways that floating point numbers are incorrectly parsed as big ints (like w/ '0x' and 'p', though IIRC, it's taken care of in other code above) and there may be a better way, like parsing a big int and observing the status code rather than doing syntactical checks. |
tf2spi
force-pushed
the
4485-fix-exact-value-float
branch
from
de1c0ee to
26f9688
Compare
tf2spi
changed the title
|
The original problem actually wasn't that ints were being parsed with 'e' notation. They were supposed to be but the destination got overwritten with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4485 by making floating point values with 'e' and without a '.' treated as floats rather than ints.