Fix bindings for uniform 1iv, 2iv, 3iv, 4iv in webgl #4507
+22
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gingerBill
reviewed
Nov 23, 2024
Comment on lines
-177
to
-180
| Uniform1iv :: proc "contextless" (location: i32, v: i32) { Uniform1i(location, v) } | ||
| Uniform2iv :: proc "contextless" (location: i32, v: glm.ivec2) { Uniform2i(location, v.x, v.y) } | ||
| Uniform3iv :: proc "contextless" (location: i32, v: glm.ivec3) { Uniform3i(location, v.x, v.y, v.z) } | ||
| Uniform4iv :: proc "contextless" (location: i32, v: glm.ivec4) { Uniform4i(location, v.x, v.y, v.z, v.w) } |
There was a problem hiding this comment.
Note you've just changed it to make it work for your use case and haven't touched the UniformNfv code above it to be "correct" either.
There was a problem hiding this comment.
Indeed, I could have also updated the UniformNfv bindings. Would you prefer that I include these fixes in this PR, or would you rather I create a new one that includes both the UniformNiv and UniformNfv fixes ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues with the bindings for
uniform1iv,uniform2iv,uniform3iv, anduniform4ivin WebGL. The implementation has been updated to align with the official WebGL API as documented on MDN Web Docs.