Ease key rotation via an array of fallback secrets #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The core change is in src/verify.ts. We don't really have to do anything special here for constant-timedness. Since each comparison is constant time, the only timing differential is between all checks (completely) failing and some check (completely) succeeding, and so the only thing learned is whether a guess was completely right or wrong. The rest of the changes here are plumbing this new mechanism up to the top level and testing. As suggested by @gr2m on #777 FIXES #770
4 tasks
|
Would it be better to implement the behaviour in In the next major release in the works #792, there is no longer any custom verify methods in the codebase. |
|
Could do if that's the better thing to do. Who else sits downstream of |
I don't think there are any of our packages that are downstream except for this one |
4 tasks
|
Closing per author comment, #770 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core change is in src/verify.ts. We don't really have to do anything special here for constant-timedness. Since each comparison is constant time, the only timing differential is between all checks (completely) failing and some check (completely) succeeding, and so the only thing learned is whether a guess was completely right or wrong.
The rest of the changes here are plumbing this new mechanism up to the top level and testing.
As suggested by @gr2m on #777
Resolves #770.
Behavior
Before the change?
After the change?
Additional info
Pull request checklist
Does this introduce a breaking change?
Pull request type
I do not seem to be able to add labels, but please add
Type: Featurefor me?