Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Szefo patches #2239

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Szefo patches #2239

wants to merge 5 commits into from

Conversation

szefo09
Copy link

@szefo09 szefo09 commented Dec 8, 2024

Fixes/Changes included:

  • Add a Fade-In/Fade-Out for Focused cards.

  • Fix issue caused by null reference exception when trying to join password protected rooms, and center every input and choice dialog window

  • Fix issue caused by skipping targetAction.FromCard.TargetsOtherCards = false;.

  • Add a more accurate sorting to Limited Game Window (sorting by two last choices).

  • Add a Return button to quickly return all cards in Deck to Limited Card Pool.
    {75E67532-6793-48DA-9DF7-B676AC9176ED}

  • Attempt to sort the filters in Limited Game more naturally (instead of sorting 1->10->2, we try to sort 1->2->10 if possible):
    {E3B817CC-740A-4B0B-BE3E-8B1D3FD84389}
    {EA622410-058A-456A-9BF7-F7FCF4B7945C}

  • Allow adding more than one Pack at a time in the Start Limited Game window:
    {B4F5E8C8-6F4D-48EF-B177-E94ABB3980F1}

@kellyelton
Copy link
Member

Just let me know when you're ready for this to get merged.

@szefo09
Copy link
Author

szefo09 commented Dec 30, 2024

Feel free to add those changes! After discussing it more in the discord, I cannot deep-dive into the engine changes, so those are what I have so far.

@szefo09
Copy link
Author

szefo09 commented Dec 31, 2024

Added changes just recently:
Fix issue caused by null reference exception when trying to join password protected rooms, and center every input and choice dialog window
Added a fade-in fade-out for focused cards to my PR. Feel free to adjust it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants